This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Issue [#94] migrate to realm #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch let error as NSError { | ||
| completion?(error: error) |
There was a problem hiding this comment.
I think we need to call the completion here, because the function is waiting for that.
There was a problem hiding this comment.
I just thinking to remove the completion as for now no method call that give parameter for completion
There was a problem hiding this comment.
May we can leave it as optional, because I think we can use later, what do you think?
…for persistHighlight
| @@ -50,6 +50,7 @@ class Highlight: Object { | |||
| try! realm.commitWrite() | |||
There was a problem hiding this comment.
Needs call completion on success write too completion?(error: nil)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from coredata to Realm and keep range startOffset and endOffset of original document to prepare migration to Rangy